Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] OPG pagerank (CUDA) #947

Merged
merged 20 commits into from
Jun 23, 2020

Conversation

afender
Copy link
Member

@afender afender commented Jun 12, 2020

1D OPG pagerank checkpoint for the CUDA part

There are still several things to do for OPG PageRank :

Close #816, progress on #485

@afender afender added the cuda label Jun 12, 2020
@afender afender requested a review from Iroy30 June 12, 2020 20:53
@afender afender requested review from a team as code owners June 12, 2020 20:53
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #947 into branch-0.15 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.15     #947   +/-   ##
============================================
  Coverage        48.89%   48.89%           
============================================
  Files               58       58           
  Lines             1579     1579           
============================================
  Hits               772      772           
  Misses             807      807           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f71b90...f9671c7. Read the comment docs.

@afender afender changed the title [WIP] OPG pagerank (CUDA) [WIP][skip-ci] OPG pagerank (CUDA) Jun 17, 2020
@afender afender changed the title [WIP][skip-ci] OPG pagerank (CUDA) [REVIEW] OPG pagerank (CUDA) Jun 18, 2020
@Iroy30 Iroy30 requested a review from a team as a code owner June 18, 2020 19:19
Copy link
Contributor

@Iroy30 Iroy30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added some wrapper edits, opg pagerank e2e runs succesfully for basic test.

@afender
Copy link
Member Author

afender commented Jun 18, 2020

rerun tests

cpp/src/link_analysis/pagerank.cu Show resolved Hide resolved
cpp/src/link_analysis/pagerank_1D.cu Outdated Show resolved Hide resolved
cpp/src/link_analysis/pagerank_1D.cu Outdated Show resolved Hide resolved
cpp/src/link_analysis/pagerank_1D.cu Outdated Show resolved Hide resolved
cpp/include/algorithms.hpp Outdated Show resolved Hide resolved
cpp/include/algorithms.hpp Outdated Show resolved Hide resolved
cpp/src/link_analysis/pagerank.cu Outdated Show resolved Hide resolved
cpp/src/link_analysis/pagerank.cu Show resolved Hide resolved
cpp/src/link_analysis/pagerank.cu Show resolved Hide resolved
cpp/src/link_analysis/pagerank_1D.cu Outdated Show resolved Hide resolved
cpp/src/link_analysis/pagerank_1D.cuh Outdated Show resolved Hide resolved
cpp/src/link_analysis/pagerank_1D.cu Outdated Show resolved Hide resolved
@BradReesWork BradReesWork added this to the 0.15 milestone Jun 19, 2020
CHANGELOG.md Show resolved Hide resolved
cpp/include/algorithms.hpp Outdated Show resolved Hide resolved
cpp/include/algorithms.hpp Outdated Show resolved Hide resolved
cpp/src/link_analysis/pagerank.cu Outdated Show resolved Hide resolved
cpp/src/link_analysis/pagerank_1D.cu Outdated Show resolved Hide resolved
cpp/src/link_analysis/pagerank_1D.cuh Outdated Show resolved Hide resolved
cpp/src/utilities/spmv_1D.cu Show resolved Hide resolved
cpp/src/utilities/spmv_1D.cu Outdated Show resolved Hide resolved
cpp/src/utilities/spmv_1D.cu Outdated Show resolved Hide resolved
cpp/src/utilities/spmv_1D.cuh Show resolved Hide resolved
@afender afender requested review from seunghwak and BradReesWork and removed request for kaatish June 19, 2020 19:01
@BradReesWork BradReesWork merged commit bc48a35 into rapidsai:branch-0.15 Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Productize OPG CSR pagerank
8 participants