Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Update scikit learn dependency #927

Merged
merged 2 commits into from
Jun 2, 2020
Merged

[REVIEW] Update scikit learn dependency #927

merged 2 commits into from
Jun 2, 2020

Conversation

hlinsen
Copy link
Contributor

@hlinsen hlinsen commented Jun 2, 2020

No description provided.

@hlinsen hlinsen requested a review from a team as a code owner June 2, 2020 18:15
@BradReesWork BradReesWork added this to the 0.14 milestone Jun 2, 2020
raydouglass
raydouglass requested changes Jun 2, 2020
View reviewed changes
Copy link
Member

@raydouglass raydouglass left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this appears to be a test-only dependency, why is it targeting v0.14 which is passing all tests with the older version?

This should go into v0.15 instead.

@BradReesWork
Copy link
Member

BradReesWork commented Jun 2, 2020 •
edited
Loading

@raydouglass This addresses an import issue that @dillon-cullinan found: https://gpuci.gpuopenanalytics.com/job/rapidsai/job/nightly-tests/job/docker-test-cugraph/511/testReport/

@raydouglass raydouglass mentioned this pull request Jun 2, 2020
Merged
@raydouglass raydouglass merged commit da0a9f8 into rapidsai:branch-0.14 Jun 2, 2020
@hlinsen hlinsen deleted the fa2-ci branch April 15, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@dillon-cullinan dillon-cullinan dillon-cullinan approved these changes

@raydouglass raydouglass raydouglass approved these changes

Assignees

@hlinsen hlinsen

Labels
None yet
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.
4 participants
@hlinsen @BradReesWork @raydouglass @dillon-cullinan