Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Katz Centrality : Auto calculation of alpha parameter if set to none #862

Merged
merged 6 commits into from
May 12, 2020

Conversation

kaatish
Copy link
Collaborator

@kaatish kaatish commented May 11, 2020

Fixes #730

  • Katz will automatically calculate alpha parameter if it is not provided by the user
  • The code will no longer inform the user if the value of alpha is greater than the minimum alpha for convergence
  • The code will no longer inform the user if the centrality calculation does not converge

@kaatish kaatish requested review from a team as code owners May 11, 2020 16:45
@GPUtester
Copy link
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@kaatish kaatish changed the title Katz Centrality : Auto calculation of alpha parameter if set to none [REVIEW] Katz Centrality : Auto calculation of alpha parameter if set to none May 11, 2020
@codecov-io
Copy link

codecov-io commented May 11, 2020

Codecov Report

Merging #862 into branch-0.14 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.14     #862   +/-   ##
============================================
  Coverage        47.66%   47.66%           
============================================
  Files               44       44           
  Lines             1328     1328           
============================================
  Hits               633      633           
  Misses             695      695           
Impacted Files Coverage Δ
python/cugraph/centrality/katz_centrality.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3136bf1...c6fc119. Read the comment docs.

@BradReesWork BradReesWork merged commit 96eeb67 into rapidsai:branch-0.14 May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Katz should auto-compute Alpha if not specified
5 participants