-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Remove gdf_column from db #802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
rerun tests |
@jwyles Test_FindMatches.fifthTest is failing |
Codecov Report
@@ Coverage Diff @@
## branch-0.14 #802 +/- ##
===============================================
- Coverage 58.14% 57.93% -0.22%
===============================================
Files 44 44
Lines 1264 1248 -16
===============================================
- Hits 735 723 -12
+ Misses 529 525 -4
Continue to review full report at Codecov.
|
This PR removes the use of gdf_column from the db code. It also re-enables find_matches tests which were previously failing in CI to see if they still fail now.