Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Remove gdf_column from db #802

Merged
merged 4 commits into from
Apr 13, 2020

Conversation

jwyles
Copy link
Contributor

@jwyles jwyles commented Apr 3, 2020

This PR removes the use of gdf_column from the db code. It also re-enables find_matches tests which were previously failing in CI to see if they still fail now.

@jwyles jwyles requested a review from a team as a code owner April 3, 2020 17:44
@jwyles jwyles changed the title Remove gdf_column from db [Review] Remove gdf_column from db Apr 3, 2020
@jwyles jwyles changed the title [Review] Remove gdf_column from db [REVIEW] Remove gdf_column from db Apr 3, 2020
Copy link
Member

@afender afender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@BradReesWork
Copy link
Member

rerun tests

@BradReesWork BradReesWork added this to the 0.14 milestone Apr 6, 2020
@BradReesWork
Copy link
Member

@jwyles Test_FindMatches.fifthTest is failing

@codecov-io
Copy link

codecov-io commented Apr 10, 2020

Codecov Report

Merging #802 into branch-0.14 will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.14     #802      +/-   ##
===============================================
- Coverage        58.14%   57.93%   -0.22%     
===============================================
  Files               44       44              
  Lines             1264     1248      -16     
===============================================
- Hits               735      723      -12     
+ Misses             529      525       -4     
Impacted Files Coverage Δ
python/cugraph/structure/graph.py 69.72% <0.00%> (-0.37%) ⬇️
python/cugraph/community/ecg.py 100.00% <0.00%> (ø)
python/cugraph/traversal/bfs.py 100.00% <0.00%> (ø)
python/cugraph/traversal/sssp.py 73.33% <0.00%> (ø)
python/cugraph/community/louvain.py 85.71% <0.00%> (ø)
python/cugraph/cores/core_number.py 100.00% <0.00%> (ø)
python/cugraph/cores/ktruss_subgraph.py 100.00% <0.00%> (ø)
python/cugraph/link_analysis/pagerank.py 100.00% <0.00%> (ø)
python/cugraph/link_prediction/jaccard.py 86.66% <0.00%> (ø)
python/cugraph/link_prediction/overlap.py 75.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8acb743...420d467. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants