Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fixing bug with disappearing get_column_data_ptr function #716

Merged
merged 2 commits into from
Feb 13, 2020
Merged

[REVIEW] Fixing bug with disappearing get_column_data_ptr function #716

merged 2 commits into from
Feb 13, 2020

Conversation

jwyles
Copy link
Contributor

@jwyles jwyles commented Feb 13, 2020

No description provided.

@jwyles jwyles requested a review from a team as a code owner February 13, 2020 01:36
@BradReesWork BradReesWork changed the title Fixing bug with disappearing get_column_data_ptr function [REVIEW] Fixing bug with disappearing get_column_data_ptr function Feb 13, 2020
BradReesWork
BradReesWork approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@BradReesWork BradReesWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will have to go back through later in this release and clean up the dead code

dantegd
dantegd approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checked and it changes all the appearances of the offending functions, so lgtm pending CI.

I would also suggest opening a github issue to not forget to do the cleanup in a follow up PR.

@BradReesWork BradReesWork merged commit 81f776b into rapidsai:branch-0.13 Feb 13, 2020
@BradReesWork BradReesWork mentioned this pull request Feb 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwyles @dantegd @BradReesWork