Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] New conda environment for 10.2 #715

Merged
merged 3 commits into from
Feb 13, 2020
Merged

[REVIEW] New conda environment for 10.2 #715

merged 3 commits into from
Feb 13, 2020

Conversation

BradReesWork
Copy link
Member

new yml file for 10.2

@BradReesWork BradReesWork requested a review from a team as a code owner February 13, 2020 01:12
@BradReesWork BradReesWork requested a review from afender February 13, 2020 01:15
@BradReesWork BradReesWork changed the title [WIP] New conda environment for 10.2 [REVIEW] New conda environment for 10.2 Feb 13, 2020
@BradReesWork
Copy link
Member Author

rerun tests

afender
afender approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@afender afender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Env file names : cudf and cuml are now using ...cudaXX.X.yml instead of ...cudaXXX.yml. We may rename ours if we want to be consistent.

@BradReesWork BradReesWork requested a review from afender February 13, 2020 17:07
afender
afender reviewed Feb 13, 2020
View reviewed changes
Copy link
Member

@afender afender left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instructions and references in
https://github.com/rapidsai/cugraph/blob/branch-0.13/CONTRIBUTING.md
Should reflect the renaming changes

@afender
Copy link
Member

afender commented Feb 13, 2020 •
edited
Loading

Probably also want to get rid of those as part of removing 9.2 references :

./README.md:98:# CUDA 9.2
./CONTRIBUTING.md:72:* CUDA 9.2+
./CONTRIBUTING.md:118:# for CUDA 9.2
./CONTRIBUTING.md:138:# for CUDA 9.2
./CONTRIBUTING.md:276:export PATH=/usr/local/cuda-10.0/bin:$PATH # or cuda-9.2 if using CUDA 9.2
./CONTRIBUTING.md:277:export LD_LIBRARY_PATH=/usr/local/cuda-10.0/lib64:$LD_LIBRARY_PATH # or cuda-9.2 if using CUDA 9.2

@BradReesWork BradReesWork merged commit 3193a4b into rapidsai:branch-0.13 Feb 13, 2020
@BradReesWork
Copy link
Member Author

Merged - now working on documents

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afender afender afender approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BradReesWork @afender