Removes unused benchmark infra: rapids-pytest-benchmark and asvdb #4865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlratzel
added
improvement
…V/asvdb any longer.
|
/merge |
|
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
rapids-pytest-benchmarkand references to one of its dependencies,asvdb.These packages were used for adding GPU memory usage to pytest-benchmark output and for updating ASV output files with pytest-benchmark results so the ASV front end can be used on pytest-benchmark suites.
Since we're not using the ASV frontend anymore, and the GPU memory usage mechanism used by rapids-pytest-benchmark is outdated and unmaintained (and slower than other tools available), we're removing references to these packages.
cc @vyasr @robertmaynard