pip devcontainers: use UCX 1.17, prefer system installation #4792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
This was referenced Nov 27, 2024
rapids-bot bot
pushed a commit
to rapidsai/nx-cugraph
that referenced
this pull request
Dec 2, 2024
… references (#53) Contributes to rapidsai/build-planning#118 Proposes the following changes for pip devcontainers: * use UCX 1.17 (ref: rapidsai/cugraph-gnn#79 (comment)) * prefer system installation of ucx to the one provided by the `libucx-cu{11,12}` wheels (ref: rapidsai/devcontainers#421 (comment)) And some other related changes noticed while doing that: * update lingering `24.*` references to `25.02` * fix `update-version.sh` so those will be correctly updated in future releases Similar to rapidsai/cugraph#4792 ## Notes for Reviewers ### How I tested this Relying on CI for most things. But for `update-version.sh`, tested like this: ```shell ./ci/release/update-version.sh '25.02.00' git grep -E '24\.' ``` Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #53
jameslamb
changed the title
AyodeAwe
approved these changes
Dec 2, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#118
Proposes the following changes for pip devcontainers:
libucx-cu{11,12}wheels (ref: prefer system installs of UCX libraries when using RAPIDS wheels devcontainers#421 (comment))And one other related change:
.devcontainer/directory (this was incorrectly spelled.devcontainers/before)