Remove GNN Packages #4765
Merged
Remove GNN Packages #4765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jameslamb
reviewed
Nov 14, 2024
There was a problem hiding this comment.
I pulled this branch and searched like this:
git grep -E -i 'dgl|pyg'Found some more things that I think should be deleted.
test files:
- https://github.com/rapidsai/cugraph/blob/branch-24.12/ci/run_cugraph_pyg_pytests.sh
- https://github.com/rapidsai/cugraph/blob/branch-24.12/ci/run_cugraph_dgl_pytests.sh
test code:
Lines 102 to 107 in c712a98
the conda recipes:
- https://github.com/rapidsai/cugraph/tree/branch-24.12/conda/recipes/cugraph-dgl
- https://github.com/rapidsai/cugraph/tree/branch-24.12/conda/recipes/cugraph-pyg
Test coverage config:
Line 4 in c712a98
Line 8 in c712a98
These should be taken care of now. |
|
The benchmarks are going to stay for now; those will go away in 25.02. |
alexbarghi-nv
added
improvement
|
CI here is going to fail until some other things are resolved.
|
…v/cugraph into remove-gnn-packages
KyleFromNVIDIA
approved these changes
Nov 19, 2024
ChuckHastings
approved these changes
Nov 21, 2024
bdice
approved these changes
Nov 22, 2024
|
/merge |
rlratzel
approved these changes
Nov 22, 2024
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 4, 2024
This repo should no longer need any build-time dependencies on cloning the `cugraph-ops` source code or pulling in its packages, as of these PRs: * #4744 * #4765 This PR proposes the following: * removing CI configuration related to cloning the `cugraph-ops` repo * removing CMake options related to `cugraph-ops` - `ALLOW_CLONE_CUGRAPH_OPS` - `CUGRAPH_EXCLUDE_CUGRAPH_OPS_FROM_ALL` - `CUGRAPH_USE_CUGRAPH_OPS_STATIC` - `USE_CUGRAPH_OPS` * removing dependencies on `pylibcugraphops` / `libcugraphops` in development scripts, conda recipes * removing the `cugraph-ops` docs, and references to them in other docs * removing unused source file `cpp/src/utilities/cugraph_ops_utils.hpp` * removing the `cugraph_ops` pytest marker ## Notes for Reviewers ### Benefits of these changes * faster CI * simplifies the pending work to introduce `libcugraph` wheel packages (rapidsai/rapids-wheels-planning#53) ### How I identified these changes ```shell git grep -i '_ops' git grep -i '\-ops' git grep -i 'cugraphops' ``` ### Why is this so big? I'd originally wanted to leave the docs-building stuff in place, but saw `docs-build` CI here failing because docs haven't been built from the `cugraph-ops` repo yet: https://github.com/rapidsai/cugraph/blob/c5d3d231c9cac361bf51246c13440a42eeda93b9/build.sh#L334-L341 Talked offline with @acostadon and @ChuckHastings , and we agreed that those docs could just be removed here. ### What is intentionally being left? * references in licenses (as some code from `cugraph-ops` is vendored here) * references in the docs for the GNN packages (`cugraph-dgl`, `cugraph-pyg`, `pylibwholegraph`), as those do still rely on `cugraph-ops` (their docs will eventually move out of this repo) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Alex Barghi (https://github.com/alexbarghi-nv) - Chuck Hastings (https://github.com/ChuckHastings) URL: #4784
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the GNN packages, which are now part of cugraph-gnn.