Update nx-cugraph to NetworkX 3.4 #4717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This run `make` in `python/nx-cugraph` directory
This was failing b/c we changed the default "fallback-to-nx" behavior right before NetworkX 3.4 was released, so now we properly handle the expected behavior in the tests based on networkx version and `nx.config.fallback_to_nx` config.
rlratzel
approved these changes
Oct 14, 2024
AyodeAwe
approved these changes
Oct 14, 2024
|
/merge |
rapids-bot
bot
merged commit 21fe9bf
into
rapidsai:branch-24.12
132 of 147 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This run
makeinpython/nx-cugraphdirectory and update the pre-commit hook.Also fixes
ego_graphtests to checknx.config.fallback_to_nxconfiguration.