Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFS imported and python bindings added. #47

Merged
merged 8 commits into from
Feb 4, 2019

Conversation

jwyles
Copy link
Contributor

@jwyles jwyles commented Jan 31, 2019

No description provided.

@GPUtester
Copy link
Contributor

Can one of the admins verify this patch?

@afender
Copy link
Member

afender commented Jan 31, 2019

We cannot not bring a static copy of CUB in cugraph repo. Also, we already access CUB from gunrock : see l190 of cmake : ${CMAKE_CURRENT_BINARY_DIR}/gunrock/externals/cub .

Having said that, if for some reason you need a copy of CUB inside cugraph, then we should do like in cuDF and add cub as a git submodule under a thirdparty directory.

@afender afender self-requested a review January 31, 2019 23:25
@afender
Copy link
Member

afender commented Feb 1, 2019

@jwyles, since RMM hooks are now in master, it would be great to make this code RMM ready. For bfs, I think you only need to :

  1. #include <rmm_utils.h>
  2. replace cudaMalloc/free by ALLOC_MANAGED_TRY / ALLOC_FREE_TRY

Please sync-up with @aschaffer if needed

@jwyles
Copy link
Contributor Author

jwyles commented Feb 1, 2019

RMM hooks have been added to BFS

Copy link
Member

@afender afender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@BradReesWork BradReesWork merged commit 2992ac2 into rapidsai:master Feb 4, 2019
@afender afender mentioned this pull request Feb 6, 2019
8 tasks
ChuckHastings pushed a commit to ChuckHastings/cugraph that referenced this pull request Oct 26, 2020
[REVIEW] Use gtest conda package in CMake/build.sh by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants