[FEA] Support Edge ID Lookup in PyLibcuGraph #4687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbarghi-nv
added
feature request
ChuckHastings
approved these changes
Oct 10, 2024
rlratzel
reviewed
Oct 14, 2024
There was a problem hiding this comment.
The Python/Cython changes look fine, just a couple of questions/requests:
- Would it be better to be more explicit and replace the word "container" with "map", since (I'm assuming) it has to be a map?
- Can you add a smoketest of some kind for the PLC updates? This would also be great for users looking for an example of how to use the new APIs.
We're calling it |
…raph into plc-eid-lookup
rlratzel
approved these changes
Oct 18, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Edge ID lookup in
pylibcugraph. Also fixes some bugs in the C API (i.e. lookup table not being cleaned up correctly, container being incorrectly dereferenced as graph).Verified in rapidsai/cugraph-gnn#50