Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the python function symmetrizing the edgelist #4649

Merged
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
f2f3a04
add new symmetrize file
jnke2016 Sep 10, 2024
0c8b927
implement symmetrize_edgelist in the CAPI
jnke2016 Sep 10, 2024
c01456a
deprecated the python symmetrize function
jnke2016 Sep 19, 2024
fb115da
expose flag symmetrizing the edgelist
jnke2016 Sep 19, 2024
47b0677
Remove python symmetrize from the SG graph creation
jnke2016 Sep 22, 2024
f09fd41
update API to symmetrize the edgelist and update docstring
jnke2016 Sep 23, 2024
b737b02
deprecate python method to symmetrize the edgelist
jnke2016 Sep 23, 2024
ea19b62
fix style
jnke2016 Sep 23, 2024
bd7eede
fix style
jnke2016 Sep 23, 2024
6e433ab
Merge remote-tracking branch 'upstream/branch-24.10' into branch-24.1…
jnke2016 Sep 23, 2024
e5c94f7
fix typo
jnke2016 Sep 23, 2024
0470299
update docstrings and remove unused function declaration
jnke2016 Sep 26, 2024
2df98f5
ensure the graph properties match when symmetrizing
jnke2016 Sep 26, 2024
fabcb37
update docstrings
jnke2016 Sep 26, 2024
3b1c1d0
update docstrings
jnke2016 Sep 26, 2024
0462529
update error reporting
jnke2016 Sep 28, 2024
e8beb72
support the symmetrization of edgelist for legacy algorithms
jnke2016 Sep 28, 2024
e3e413b
fix typo
jnke2016 Sep 29, 2024
5336a91
fix property_graph tests
jnke2016 Sep 29, 2024
3b40fc5
update graph creation for the C tests
jnke2016 Sep 29, 2024
cbbfb88
update the test to call the deprecated symmetrize
jnke2016 Oct 1, 2024
8891b1f
fix typo
jnke2016 Oct 1, 2024
4e9e85d
fix typo
jnke2016 Oct 1, 2024
d135ac1
undo changes to symmetrize
jnke2016 Oct 1, 2024
a9c7064
fix typo
jnke2016 Oct 1, 2024
1c70046
use the deprecated symmetrize call
jnke2016 Oct 1, 2024
2cfb0fb
update SG graph creation
jnke2016 Oct 1, 2024
fec091f
Merge remote-tracking branch 'upstream/branch-24.10' into branch-24.1…
jnke2016 Oct 1, 2024
efbdb38
fix style
jnke2016 Oct 1, 2024
35c25db
fix style
jnke2016 Oct 1, 2024
f91bb81
remove debug print and pass kwarg name
jnke2016 Oct 2, 2024
0389f27
call deprecated symmetrize call
jnke2016 Oct 2, 2024
97472cd
update flag passed to the deprecated symmetrize function
jnke2016 Oct 2, 2024
ec7da8d
fix style
jnke2016 Oct 2, 2024
0e5a9ba
update docstrings
jnke2016 Oct 2, 2024
2a78356
remove redundant assignments
jnke2016 Oct 2, 2024
43ba0cd
ignore deprecation warning for symmetrizing
jnke2016 Oct 2, 2024
cfecd90
symmetrize
jnke2016 Oct 2, 2024
96d2e20
fix style
jnke2016 Oct 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
symmetrize
jnke2016 committed Oct 2, 2024

Verified

This commit was signed with the committer’s verified signature.
seunghwak Seunghwa Kang
commit cfecd907a4baccdebdd1a284dae67248af195d51
Original file line number Diff line number Diff line change
@@ -27,6 +27,7 @@
from cugraph.dask import uniform_neighbor_sample
from cugraph.dask.common.mg_utils import is_single_gpu
from cugraph.structure.symmetrize import _memory_efficient_drop_duplicates
from cugraph.structure.symmetrize import symmetrize_ddf
from cugraph.datasets import email_Eu_core, small_tree
from pylibcugraph.testing.utils import gen_fixture_params_product

@@ -144,6 +145,12 @@ def test_mg_uniform_neighbor_sample_simple(dask_client, input_combo):
input_df, vertex_col_name, len(workers)
)

input_df = symmetrize_ddf(
input_df,
src_name="src",
dst_name = "dst",
symmetrize=not dg.is_directed())

result_nbr = uniform_neighbor_sample(
dg,
input_combo["start_list"],
@@ -247,6 +254,13 @@ def test_mg_uniform_neighbor_sample_tree(dask_client, directed):
# input_df != ddf if 'directed = False' because ddf will be symmetrized
# internally.
input_df = G.input_df

input_df = symmetrize_ddf(
input_df,
src_name="src",
dst_name = "dst",
symmetrize=not G.is_directed())

join = result_nbr.merge(
input_df, left_on=[*result_nbr.columns[:2]], right_on=[*input_df.columns[:2]]
)