Add support for Python 3.12 #4647
Conversation
jameslamb
added
non-breaking
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
jameslamb
changed the title
|
Restarted CI here now that there are Python 3.12 packages for Will put this up for review once I see enough of CI passing. |
| tar.extractall(str(curr_resultset_download_dir)) | ||
| # TODO: pass filter="fully_trusted" when minimum supported Python version >=3.12 | ||
| # ref: https://docs.python.org/3/library/tarfile.html#tarfile-extraction-filter | ||
| with warnings.catch_warnings(): |
There was a problem hiding this comment.
Starting with Python 3.12, using tar.extractall() without passing the filter argument raises this DeprecationWarning:
DeprecationWarning: Python 3.14 will, by default, filter extracted tar archives and reject files or modify their metadata. Use the filter argument to control this behavior.
That warning is treated as an error for CI here, so I added this warning filter to allow these tests to pass.
jameslamb
changed the title
jameslamb
requested review from
bdice
and removed request for
KyleFromNVIDIA
| @@ -28,7 +28,7 @@ concurrency: | |||
| jobs: | |||
| cpp-build: | |||
| secrets: inherit | |||
| uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-build.yaml@branch-24.10 | |||
| uses: rapidsai/shared-workflows/.github/workflows/conda-cpp-build.yaml@python-3.12 | |||
There was a problem hiding this comment.
just curious if this is a new naming convention (going from RAPIDS branch name to python version) or just a temporary change for python 3.12
There was a problem hiding this comment.
Fair question! Nope this is only temporary.
The process I'm using is like this:
- put up CI changes on a new
shared-workflowsbranch: Add Python 3.12. shared-workflows#213 - migrate all the repos to using those new CI configs one-by-one (with PRs like this one)
- once everything is migrated, merge those changes into
shared-workflows - change all the repos back to referencing a
branch-{YY}.{MM}branch
This way, we can do the work incrementally. Instead of, say, adding Python 3.12 jobs that then all RAPIDS repos have to immediately become compliant with.
|
/merge |
rapids-bot
bot
merged commit 7c86b98
into
rapidsai:branch-24.10
…711) Contributes to rapidsai/build-planning#40. * adds Python 3.12 images * defaults to latest Python (3.12) and CUDA (12.5[.1]) in docs and comments ## Notes for Reviewers Builds here will fail until all RAPIDS libraries are supporting Python 3.12, but figured we don't need to wait on that to come to an agreement about the building and testing matrices. Blocked by: * [x] rapidsai/cuml#6060 * [x] rapidsai/cugraph#4647 * [x] rapidsai/integration#719 Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Bradley Dice (https://github.com/bdice) URL: #711
Description
Contributes to rapidsai/build-planning#40
This PR adds support for Python 3.12.
Notes for Reviewers
This is part of ongoing work to add Python 3.12 support across RAPIDS.
It temporarily introduces a build/test matrix including Python 3.12, from rapidsai/shared-workflows#213.
A follow-up PR will revert back to pointing at the
branch-24.10branch ofshared-workflowsonce allRAPIDS repos have added Python 3.12 support.
This will fail until all dependencies have been updates to Python 3.12
CI here is expected to fail until all of this project's upstream dependencies support Python 3.12.
This can be merged whenever all CI jobs are passing.