Update edge triangle count to call a non detail primitive #4630
Conversation
…0_non-detail-prim-nbr_intersection
jnke2016
changed the title
|
|
||
| namespace cugraph { | ||
|
|
||
| namespace detail { |
There was a problem hiding this comment.
Don't need to define an empty detail namespace.
|
|
||
| #include <rmm/exec_policy.hpp> | ||
|
|
||
| #include <thrust/binary_search.h> |
There was a problem hiding this comment.
I don't think any of these thrust includes are necessary.
You might want to review all of your includes to reduce them just to what's directly used in this file.
| @@ -0,0 +1,105 @@ | |||
| /* | |||
| * Copyright (c) 2022-2024, NVIDIA CORPORATION. | |||
There was a problem hiding this comment.
This should probably just be 2024.
| { | ||
| static_assert(!GraphViewType::is_storage_transposed); | ||
|
|
||
| if (do_expensive_check) { |
There was a problem hiding this comment.
Is there a reason to duplicate this error check? Couldn't you just pass do_expensive_check directly to the detail::nbr_intersection and let it do this check (it already does).
| "Invalid input arguments: there are invalid input vertex pairs."); | ||
| } | ||
|
|
||
| auto [intersection_offsets, intersection_indices] = |
There was a problem hiding this comment.
You should be able to just return the results directly...
return detail::nbr_intersection(handle,
...
instead of capturing and then immediately returning the result.
ChuckHastings
added
improvement
| * @param graph_view Non-owning graph object. | ||
| * @param vertex_pair_first Iterator pointing to the first (inclusive) input vertex pair. | ||
| * @param vertex_pair_last Iterator pointing to the last (exclusive) input vertex pair. | ||
| * @param A flag to run expensive checks for input arguments (if set to `true`). |
There was a problem hiding this comment.
Documentation for return values is missing (@return)
…0_non-detail-prim-nbr_intersection
|
/merge |
Create a non detail primitive that iterates over each input vertex pair and returns the common destination neighbor list
pair in a CSR-like format.
closes #3475