Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Additional Check for NetworkX Release Candidate Versions #4613

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

nv-rliu
Copy link
Contributor

@nv-rliu nv-rliu commented Aug 15, 2024

Part of https://github.com/rapidsai/graph_dl/issues/579

This PR allows nx-cugraph to operate with release candidate (under development) versions of networkx

What This Pattern Allows:

  • Just a single digit: 3.4, 3.9, etc

  • Release Candidate format: 3.4rc0. 3.7rc2

This is needed to complete adding nightly test coverage for development branches of nx

@nv-rliu nv-rliu added improvement Improvement / enhancement to an existing function breaking Breaking change labels Aug 15, 2024
@nv-rliu nv-rliu added this to the 24.10 milestone Aug 15, 2024
@nv-rliu nv-rliu requested review from eriknw and rlratzel August 15, 2024 19:29
@nv-rliu nv-rliu requested a review from a team as a code owner August 15, 2024 19:29
Copy link
Contributor

@eriknw eriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nv-rliu, and my bad for missing this!

Btw, re.match already matches only from the beginning of the line, so beginning the pattern with "^" is not strictly necessary, but it's fine to be explicit.

@nv-rliu
Copy link
Contributor Author

nv-rliu commented Aug 16, 2024

Thanks @nv-rliu, and my bad for missing this!

Btw, re.match already matches only from the beginning of the line, so beginning the pattern with "^" is not strictly necessary, but it's fine to be explicit.

Thanks for the review. And neat tip! TIL 😄

@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit a6a84eb into rapidsai:branch-24.10 Aug 16, 2024
103 checks passed
@nv-rliu nv-rliu deleted the nx-version-check branch August 16, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants