Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add setuptools to host requirements for conda packages that need it #4582

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Jul 31, 2024

@caryr35 pointed out to me this morning that cugraph's nightly CI is failing. All conda-python-build jobs are failing like this, when building nx-cugraph

ModuleNotFoundError: No module named 'setuptools'
...
ValueError: Could not import build backend specified in pyproject.toml's tool.rapids-build-backend table. Make sure you specified the right optional dependency in your build-system.requires entry for rapids-build-backend.

(build link)

suspected root cause: nx-cugraph uses setuptools.build_meta, but setuptools isn't present in the conda build environment

Notes for Reviewers

Why is this targeting branch-24.08?

Looks like CI is failing there too: https://github.com/rapidsai/cugraph/actions/runs/10183681336/job/28171285190

Why is this just breaking now?

I suspect that prior to this we were getting setuptools because it was a transitive dependency of one of nx-cugraph's other build/host dependencies.

How could we prevent stuff like this in the future?

We could add support for updating conda recipe files in rapids-dependency-file-generator (rapidsai/dependency-file-generator#7).

setuptools was correctly added as a build dependency in pyproject.toml files here (automatically, via dependencies.yaml + rapids-dependency-file-generator), but the conda recipe meta.yaml files were missed.

@github-actions github-actions bot added the conda label Jul 31, 2024
@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change bug Something isn't working and removed conda improvement Improvement / enhancement to an existing function labels Jul 31, 2024
@jameslamb jameslamb changed the base branch from branch-24.10 to branch-24.08 July 31, 2024 17:22
@jameslamb jameslamb changed the title WIP: add setuptools to host requirements for conda packages that need it add setuptools to host requirements for conda packages that need it Jul 31, 2024
@github-actions github-actions bot added the conda label Jul 31, 2024
@jameslamb jameslamb marked this pull request as ready for review July 31, 2024 17:28
@jameslamb jameslamb requested a review from a team as a code owner July 31, 2024 17:28
@jameslamb jameslamb requested a review from raydouglass July 31, 2024 17:28
@alexbarghi-nv
Copy link
Member

It looks like cugraph-pyg has not been updated

@jameslamb
Copy link
Member Author

It looks like cugraph-pyg has not been updated

Ah! Thanks, updated in 6774dcd. I'd missed that one because I saw scikit-build-core in its conda recipe. Looks like that was incorrect, it really does use setuptools:

build-backend = "setuptools.build_meta"

Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, @jameslamb !

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 969ea3e into rapidsai:branch-24.08 Jul 31, 2024
131 of 146 checks passed
@jameslamb jameslamb deleted the setuptools-dep branch August 1, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conda non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants