-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add setuptools to host requirements for conda packages that need it #4582
Conversation
8ea7882
to
2f582ce
Compare
It looks like cugraph-pyg has not been updated |
Ah! Thanks, updated in 6774dcd. I'd missed that one because I saw cugraph/python/cugraph-pyg/pyproject.toml Line 68 in b38e010
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, @jameslamb !
/merge |
969ea3e
into
rapidsai:branch-24.08
@caryr35 pointed out to me this morning that
cugraph
's nightly CI is failing. Allconda-python-build
jobs are failing like this, when buildingnx-cugraph
(build link)
suspected root cause:
nx-cugraph
usessetuptools.build_meta
, butsetuptools
isn't present in the conda build environmentNotes for Reviewers
Why is this targeting
branch-24.08
?Looks like CI is failing there too: https://github.com/rapidsai/cugraph/actions/runs/10183681336/job/28171285190
Why is this just breaking now?
I suspect that prior to this we were getting
setuptools
because it was a transitive dependency of one ofnx-cugraph
's other build/host dependencies.How could we prevent stuff like this in the future?
We could add support for updating conda recipe files in
rapids-dependency-file-generator
(rapidsai/dependency-file-generator#7).setuptools
was correctly added as a build dependency inpyproject.toml
files here (automatically, viadependencies.yaml
+rapids-dependency-file-generator
), but the conda recipemeta.yaml
files were missed.