nx-cugraph: check networkx version #4571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlratzel
added
improvement
rlratzel
approved these changes
Jul 31, 2024
|
/merge |
rapids-bot
bot
merged commit d77a2d6
into
rapidsai:branch-24.08
130 of 131 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address the feedback from @bdice in #4531 (comment), which I was unable to do in that PR.
I know checking version strings is playing it fast-and-loose, but I believe we are abundantly safe to do so here, as networkx releases have been, and are expected to be, slow and predictable. Also, we do not have
packagingas a runtime dependency (it is a test dependency for finer control).So, even better than using
packaging.version.parse, this PR performs a sanity check on the networkx version. I put it in bothnx_cugraph.__init__and_nx_cugraph.__init__to give us obvious breadcrumbs to discover and follow.