Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure get_test_data.sh doesn't re-download datasets #4536

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

trxcllnt
Copy link
Collaborator

  • support calling get_test_data.sh from any directory
  • only download datasets if newer than local copies
  • extract datasets in parallel

After this PR, datasets will be stored in datasets/tmp and not deleted after extraction, because wget -N (aka --timestamping) relies on comparing the local and remote mtimes.

* only download datasets if newer than local copies
* extract datasets in parallel
@trxcllnt trxcllnt requested a review from a team as a code owner July 12, 2024 17:17
@trxcllnt trxcllnt added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 12, 2024
@rlratzel
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 8829aa9 into rapidsai:branch-24.08 Jul 17, 2024
131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasets improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants