Define and Implement C API for biased sampling #4535
Conversation
ChuckHastings
added
improvement
| const cugraph_graph_t * graph, | ||
| const cugraph_lookup_container_t* lookup_container, | ||
| const cugraph_type_erased_device_array_t* edge_ids, | ||
| const cugraph_type_erased_device_array_t* properties, |
There was a problem hiding this comment.
What happens if edge IDs are provided only for a subset of edges? Will those edges have undefined values? Should we ask for default values?
And no need for an update function? (e.g. update bias values only for a small subset of edges).
There was a problem hiding this comment.
Reasonable ideas. I'll look at defining update functions and a mechanism for a default value. I'll add it to both vertex and edge functions.
There was a problem hiding this comment.
Just fyi. In the C++ primitives level, we have fill_edge_property_value (which sets edge property values for the entire set of edges, we may add a function that works on a subset of the edges in the future) and update_edge_property function that works either on a subset of the edges or the entire set of edges. Following this may make implementing the API easier.
There was a problem hiding this comment.
I pushed an update that adds these functions. Plan is to implement them at some point in the future.
ChuckHastings
changed the title
|
/merge |
Defined and implements C API for biased sampling.
API includes a parameter for handling edge bias input that is not the weight of the edge. However, there is currently no mechanism to create the
cugraph_edge_property_view_t *value that would need to be passed in. There are some proposed functions to support that included inproperty.h, but they are inside an#ifdef 0block so that they won't be compiled.