Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and test with CUDA 12.5.1 #4534

Merged
merged 7 commits into from
Jul 17, 2024
Merged

Build and test with CUDA 12.5.1 #4534

merged 7 commits into from
Jul 17, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Jul 11, 2024 •
edited
Loading

This PR updates the latest CUDA build/test version 12.2.2 to 12.5.1.

Contributes to rapidsai/build-planning#73

@KyleFromNVIDIA KyleFromNVIDIA added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 11, 2024
@github-actions github-actions bot added the conda label Jul 11, 2024
@KyleFromNVIDIA KyleFromNVIDIA marked this pull request as ready for review July 16, 2024 13:26
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners July 16, 2024 13:26
@KyleFromNVIDIA KyleFromNVIDIA requested a review from jameslamb July 16, 2024 13:26
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner July 16, 2024 16:12
@KyleFromNVIDIA KyleFromNVIDIA mentioned this pull request Jul 16, 2024
Merged
jameslamb
jameslamb approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one more small docs thing to fix.

docs/cugraph/source/installation/source_build.md Show resolved Hide resolved
@jakirkham
Copy link
Member

jakirkham commented Jul 16, 2024 •
edited
Loading

Should we update these lines from CUDA 12.0 to 12.5?

https://github.com/rapidsai/cugraph/blame/5cdef4ef7f0df564fd85088c86e0e961958c5ef5/notebooks/README.md#L70

https://github.com/rapidsai/cugraph/blame/5cdef4ef7f0df564fd85088c86e0e961958c5ef5/notebooks/README.md#L76

https://github.com/rapidsai/cugraph/blame/5cdef4ef7f0df564fd85088c86e0e961958c5ef5/notebooks/README.md#L92

@jameslamb
Copy link
Member

should we update these lines from CUDA 12.0 to 12.5

We couldn't update them to 12.5 yet, as we aren't yet publishing 12.5 images from rapidsai/docker (rapidsai/build-planning#73 (comment)).

Since it seems like the offline discussion on that issue is trending towards "let's add 12.5 images", and since cugraph's CI takes so long to run, I think we should NOT update those lines from 12.0 to 12.5 in this PR, or block this PR until those new images are available.

I think we should merge this once CI passes, and go back over RAPIDS with a pass for these image tags once we're publishing 12.5 images from rapidsai/docker.

@jakirkham
Copy link
Member

Given we didn't update them before, not updating would be ok

I think we should merge this once CI passes, and go back over RAPIDS with a pass for these image tags once we're publishing 12.5 images from rapidsai/docker.

SGTM

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 710e31a into rapidsai:branch-24.08 Jul 17, 2024
132 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@jameslamb jameslamb jameslamb approved these changes

@jakirkham jakirkham jakirkham approved these changes

Assignees
No one assigned
Labels
conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KyleFromNVIDIA @jakirkham @jameslamb @ChuckHastings