Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance optimize BFS (including direction optimizing BFS implementation, mainly for single-GPU) #4527

Merged
merged 31 commits into from
Jul 10, 2024
Merged

Performance optimize BFS (including direction optimizing BFS implementation, mainly for single-GPU) #4527

merged 31 commits into from
Jul 10, 2024

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Jul 8, 2024 •
edited by ChuckHastings
Loading

This PR includes multiple performance optimizations to improve BFS performance (including direction optimizing BFS for symmetric graphs).

  • Implement direction optimizing BFS
  • Add the transform_reduce_v_frontier_outgoing_e_by_src primitive (this resembles transform_reduce_v_frontier_outgoing_e_by_dst but performs reduction based on src)
  • Update the fill_edge_src|dst_property to take the fill value as the last input parameter (to be consistent with thrust::fill or std::fill)
  • Update the fill_edge_src|dst_property to take a vertex list to fill only a subset of vertex property values.
  • Update the update_edge_src|dst_property primitive to take a mutable view (to be consistent with other primitives)
  • Update the vertex_frontier bucket to take a raft::device_span (supports creation of non-owning bucket, this saves a copy operation in some cases)
  • Fix compiler warnings (cuda 12.4)
  • Few updates in code cosmetics.

closes https://github.com/rapidsai/graph_dl/issues/544

seunghwak added 28 commits June 4, 2024 15:55
@seunghwak
update BFS tests for better testing performance
7afe54d
@seunghwak
Merge branch 'branch-24.08' of https://github.com/rapidsai/cugraph in…
5bbcfcf 
…to enh_direction_optimizing_bfs
@seunghwak
Merge branch 'branch-24.08' of https://github.com/rapidsai/cugraph in…
50bc7a5 
…to enh_direction_optimizing_bfs
@seunghwak
Merge branch 'branch-24.08' of https://github.com/rapidsai/cugraph in…
8ea68f0 
…to enh_direction_optimizing_bfs
@seunghwak
add transform_reduce_v_frontier_outgoing_e_by_src
c40bb4f
@seunghwak
file rename
11eb160
@seunghwak
update to support reduce_by_src
fa99463
@seunghwak
test file renaming
fed013c
@seunghwak
Merge branch 'branch-24.08' of https://github.com/rapidsai/cugraph in…
68c910e 
…to enh_direction_optimizing_bfs
@seunghwak
draft implementation of direction optimizing BFs
aa55fa4
@seunghwak
update bfs test
d738419
@seunghwak
fix compiler warnings
f6a945b
@seunghwak
add constructors to create a bucket from R-value device_uvector objects
c9a075e
@seunghwak
update fill_edge_src|dst_property to take vertex list
87e153b
@seunghwak
update fill_edge_src|dst_property and fill_edge_property to take a mu…
447520e 
…table_view and change the order of mutalbe_view and fill value in the input parameter list
@seunghwak
update update_edge_src|dst_property to take a mutalbe_view()
f04c402
@seunghwak
cosmetic updates
f3fa504
@seunghwak
update fill_edge_src_dst_property to support thrust tuple of packed bool
f26445d
@seunghwak
Merge branch 'branch-24.08' of https://github.com/rapidsai/cugraph in…
1b34617 
…to enh_direction_optimizing_bfs
@seunghwak
update compute_major_degrees
1351fb4
@seunghwak
Merge branch 'branch-24.08' of https://github.com/rapidsai/cugraph in…
c26f633 
…to enh_direction_optimizing_bfs
@seunghwak
Merge branch 'branch-24.08' of https://github.com/rapidsai/cugraph in…
5d4d65b 
…to enh_direction_optimizing_bfs
@seunghwak
Merge branch 'branch-24.08' of https://github.com/rapidsai/cugraph in…
a70a624 
…to enh_direction_optimizing_bfs
@seunghwak
Merge branch 'branch-24.08' of https://github.com/rapidsai/cugraph in…
117355c 
…to enh_direction_optimizing_bfs
@seunghwak
update extract_transform_v_frontier_e to support early exit for direc…
8f2f464 
…tion optimizing BFS
@seunghwak
update vertex_frontier bucket to take a raft::device_span
e5956de
@seunghwak
implement direction optimizing BFS
0ae0411
@seunghwak
update mg bfs test
0a12ce2
@seunghwak seunghwak requested review from a team as code owners July 8, 2024 23:38
@seunghwak seunghwak self-assigned this Jul 8, 2024
@seunghwak seunghwak added this to the 24.08 milestone Jul 8, 2024
@seunghwak seunghwak added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 8, 2024
jnke2016
jnke2016 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@jnke2016 jnke2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit b55c279 into rapidsai:branch-24.08 Jul 10, 2024
135 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnke2016 jnke2016 jnke2016 approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

Assignees

@seunghwak seunghwak

Labels
CMake cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
24.08
Development

Successfully merging this pull request may close these issues.
3 participants
@seunghwak @ChuckHastings @jnke2016