Fix OOM Bug for Jaccard, Sorensen, and Overlap benchmarks #4524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnke2016
reviewed
Jul 8, 2024
jnke2016
requested changes
Jul 8, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4510
This PR fixes a bug in
benchmarks/cugraph/pytest-based/bench_algos.pyfor Jaccard and Overlap (and adds Sorensen to the list of algos to be run).The reason for the error was that the benchmarks were trying to compute two_hop_neighbors on all nodes which would cause the GPU to run out of memory.