Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid --find-links in wheel jobs #4509

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#69
Contributes to rapidsai/build-planning#33

Proposes a stricter pattern for passing a pylibcugraph wheel from the wheel-build-cpp job that produced it into the wheel-build-python job wanting to use it (as a build dependency of cugraph). This change improves the likelihood that issues with the pylibcugraph wheels will be caught in CI.

Notes for Reviewers

See rapidsai/rmm#1586 and rapidsai/build-planning#69 (comment) for details on how I tested this approach.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 27, 2024
@github-actions github-actions bot added the ci label Jun 27, 2024
@jameslamb jameslamb changed the title WIP: Avoid --find-links in wheel jobs Avoid --find-links in wheel jobs Jun 27, 2024
@jameslamb jameslamb marked this pull request as ready for review June 27, 2024 22:48
@jameslamb jameslamb requested a review from a team as a code owner June 27, 2024 22:48
@jameslamb jameslamb requested a review from msarahan June 27, 2024 22:48
Copy link
Contributor

@msarahan msarahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's counterintuitive to me how this works, but I also think that it is a good idea. The counterintuitive part is how we're using constraints to specify the path to the file. It's not wrong, it just isn't a use for the constraints file that I had considered.

@jameslamb
Copy link
Member Author

It's counterintuitive to me how this works, but I also think that it is a good idea. The counterintuitive part is how we're using constraints to specify the path to the file. It's not wrong, it just isn't a use for the constraints file that I had considered.

Thanks for the careful review @msarahan .

I agree, it is definitely counterintuitive at first (I tried several other ideas before landing on this one). I think because we're in this situation where we both want to use build isolation but also want very fine-grained control over some characteristics of the build environment. If we wanted much more control than this, it'd probably be time to just abandon build isolation (I mentioned that near the end of rapidsai/build-planning#79, a potential follow-up to this).

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit b9001f9 into rapidsai:branch-24.08 Jul 3, 2024
131 checks passed
@jameslamb jameslamb deleted the remove-find-links branch July 3, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants