Split CPP libraries into separate wheels #4507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
reviewed
Jun 26, 2024
| "cupy-cuda11x>=12.0.0", | ||
| "libcugraph==24.6.*", | ||
| "pylibraft==24.6.*", | ||
| "rmm==24.6.*", |
There was a problem hiding this comment.
hey @msarahan I know this is still a draft and not ready for review, but was just skimming it and wanted to note that I noticed this... looks like you still have a bunch of 24.6 dependencies in here, even though this is targeting release 24.08. Those should all get updated.
ci/release/update-version.sh '24.08.00'There was a problem hiding this comment.
I think that should be changed in dependencies.yaml, and then this pyproject.toml should be regenerated. At any rate, thanks. I have only just merged in branch-24.08, and will start seeing what other fixes are necessary.
|
I was wrong about not being able to push to Vyas' branch. I didn't have my SSO configured for SSH keys. I'm closing this PR and working on #4340 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a duplicate of #4340. I'm putting it up as a new PR because I'm taking over the work, but I don't have permissions to push directly to Vyas' fork (I guess I'm not a maintainer here).
I'm happy to close this PR if it is preferable to sort out permissions for me to push to Vyas' fork.