Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute cosine similarity for vertex pairs #4482

Merged
merged 7 commits into from
Jun 19, 2024
Merged

compute cosine similarity for vertex pairs #4482

merged 7 commits into from
Jun 19, 2024

Conversation

naimnv
Copy link
Contributor

@naimnv naimnv commented Jun 11, 2024 •
edited
Loading

compute cosine similarity for vertex pairs

@naimnv naimnv requested review from a team as code owners June 11, 2024 21:57
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 11, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@naimnv naimnv marked this pull request as draft June 11, 2024 21:57
@naimnv naimnv changed the title cosine similarity compute cosine similarity for vertex paris Jun 11, 2024
@naimnv naimnv changed the title compute cosine similarity for vertex paris compute cosine similarity for vertex pairs Jun 11, 2024
@naimnv naimnv self-assigned this Jun 11, 2024
@naimnv naimnv added this to the 24.08 milestone Jun 11, 2024
@naimnv naimnv added feature request New feature or request non-breaking Non-breaking change labels Jun 11, 2024
@naimnv naimnv marked this pull request as ready for review June 11, 2024 23:33
@naimnv naimnv marked this pull request as draft June 11, 2024 23:35
@naimnv naimnv removed the request for review from seunghwak June 11, 2024 23:36
@naimnv naimnv marked this pull request as ready for review June 13, 2024 22:21
seunghwak
seunghwak approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for few minor cosmetic issues.

cpp/src/link_prediction/similarity_impl.cuh Outdated Show resolved Hide resolved
cpp/src/link_prediction/similarity_impl.cuh Outdated Show resolved Hide resolved
@BradReesWork
Copy link
Member

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented Jun 19, 2024

@BradReesWork I'm waiting for the CI being unblocked before triggering the CI.

@naimnv
Copy link
Contributor Author

naimnv commented Jun 19, 2024

/okay to test

@naimnv
Copy link
Contributor Author

naimnv commented Jun 19, 2024

/merge

@rapids-bot rapids-bot bot merged commit e4d51b2 into rapidsai:branch-24.08 Jun 19, 2024
131 checks passed
@naimnv naimnv linked an issue Jun 30, 2024 that may be closed by this pull request
[FEA]: Add Cosine Similarity to cuGraph #2993
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

@ChuckHastings ChuckHastings Awaiting requested review from ChuckHastings

Assignees

@naimnv naimnv

Labels
CMake cuGraph feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
24.08
Development

Successfully merging this pull request may close these issues.

[FEA]: Add Cosine Similarity to cuGraph
3 participants
@naimnv @BradReesWork @seunghwak