-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update decompress_to_edgelist to handle edge types #4397
Update decompress_to_edgelist to handle edge types #4397
Conversation
…e_drecompress_to_edgelist
/okay to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but @jnke2016 needs a decompress_to_edgelist function that takes just a graph view object and an edge_property_device_view_t object of integer types (i.e. int32_t and int64_t for now, and in the future, we may need to support floating point types as well). Do you think it is better to implement this in this PR or address this in a separate PR?
He can just pass it instead of edge_id_view if edge_property_device_view_t object is of integer types (i.e. int32_t and int64_t Otherwise we need an additional 72 explicit instantiations and I can address it in a separate PR. |
Why 72? I assume 3 (vertex_t & edge_t combinations) * 4 (store_transposed & multi_gpu) * 2 (Int32_t & int64_t) = 24. And eventually, we may remove 32 bit vertex ID and 64 bit edge ID support and may change store_transposed & multi_gpu as run-time parameters, so this will become more like 4. |
/okay to test |
/okay to test |
/merge |
79acec9
into
rapidsai:branch-24.06
Update decompress_to_edgelist to handle edge types