-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address dask_cudf.read_csv chunksize deprecation #4379
Address dask_cudf.read_csv chunksize deprecation #4379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, @mroeschke !
So is blocksize
simply a rename of the old chunksize
arg, or are there bigger differences? I'm just asking in case we also need to update get_chunksize() to return something that's computed differently.
I believe the change is just a pure renamed based on rapidsai/cudf#12394, but tagging @rjzamora just to confirm |
Yeah, I believe someone arbitrarily chose the name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/merge |
xref #4271
chunksize
was deprecated in favor ofblocksize
Also removed an unsupported
chunksize
in acudf.read_csv
call