Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false C++ HITS test failure on H100 #4352

Merged

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Apr 16, 2024

Threshold for comparing cugraph & reference HITS results (floating point numbers) was too tight leading to false alarms in H100. This PR increases the threshold to avoid the false alarm.

@seunghwak seunghwak added the DO NOT MERGE Hold off on merging; see PR for details label Apr 16, 2024
@seunghwak seunghwak self-assigned this Apr 16, 2024
@seunghwak seunghwak added bug Something isn't working non-breaking Non-breaking change and removed DO NOT MERGE Hold off on merging; see PR for details labels Apr 17, 2024
@seunghwak seunghwak marked this pull request as ready for review April 17, 2024 15:51
@seunghwak seunghwak requested a review from a team as a code owner April 17, 2024 15:51
@seunghwak seunghwak changed the title Debug C++ HITS test failure on H100 Fix false C++ HITS test failure on H100 Apr 17, 2024
@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit c31cd63 into rapidsai:branch-24.06 Apr 19, 2024
131 checks passed
@seunghwak seunghwak deleted the bug_hits_test_failure_on_h100 branch May 22, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuGraph non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants