-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false C++ HITS test failure on H100 #4352
Merged
rapids-bot
merged 9 commits into
rapidsai:branch-24.06
from
seunghwak:bug_hits_test_failure_on_h100
Apr 19, 2024
Merged
Fix false C++ HITS test failure on H100 #4352
rapids-bot
merged 9 commits into
rapidsai:branch-24.06
from
seunghwak:bug_hits_test_failure_on_h100
Apr 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to bug_hits_test_failure_on_h100
seunghwak
added
bug
Something isn't working
non-breaking
Non-breaking change
and removed
DO NOT MERGE
Hold off on merging; see PR for details
labels
Apr 17, 2024
seunghwak
changed the title
Debug C++ HITS test failure on H100
Fix false C++ HITS test failure on H100
Apr 17, 2024
naimnv
approved these changes
Apr 17, 2024
ChuckHastings
approved these changes
Apr 19, 2024
…to bug_hits_test_failure_on_h100
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Threshold for comparing cugraph & reference HITS results (floating point numbers) was too tight leading to false alarms in H100. This PR increases the threshold to avoid the false alarm.