Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in cugraph::detail::extract_transform_v_froniter_e #4320

Merged
merged 4 commits into from
Apr 16, 2024

Conversation

seunghwak
Copy link
Contributor

Fix a bug potentially accessing thrust::optional object's value when the optional object does not contain a value (thrust::nullopt).

This may manifest only when cugraph is built with a debug option (no deadcode elimination optimization).

@seunghwak seunghwak added bug Something isn't working non-breaking Non-breaking change labels Apr 8, 2024
@seunghwak seunghwak added this to the 24.06 milestone Apr 8, 2024
@seunghwak seunghwak self-assigned this Apr 8, 2024
@seunghwak seunghwak requested a review from a team as a code owner April 8, 2024 18:08
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixes the bug in the debug build that I found. Looks like style checks need updating before CI will pass, though.

raydouglass pushed a commit that referenced this pull request Apr 9, 2024
This PR updates the nx-cugraph README.md with the latest upstream URLs
by running the `update_readme.py` script on a current `objects.inv` file
downloaded from NetworkX. The latest `objects.inv` file has updated
URLs, which results in links in the README being updated too.

This should resolve style check errors recently seen in [other
PRs](#4320) due to the upstream
change in `objects.inv` in NetworkX. Since CI runs pre-commit on all
files, this caused the nx-cugraph checks to run on PRs that didn't
change nx-cugraph files.
@vyasr
Copy link
Contributor

vyasr commented Apr 16, 2024

/merge

@rapids-bot rapids-bot bot merged commit 938b298 into rapidsai:branch-24.06 Apr 16, 2024
135 checks passed
@seunghwak seunghwak deleted the bug_prim_hypersparse branch May 22, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuGraph non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants