Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of sentinel namespace #4274

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Get rid of sentinel namespace
PointKernel committed Mar 24, 2024

Verified

This commit was signed with the committer’s verified signature.
PointKernel Yunsong Wang
commit d624ce15278a3377ebc1ecff9bf0b627208e1303
2 changes: 1 addition & 1 deletion cpp/src/prims/key_store.cuh
Original file line number Diff line number Diff line change
@@ -326,7 +326,7 @@ class key_cuco_store_t {
rmm::mr::polymorphic_allocator<std::byte>(rmm::mr::get_current_device_resource()), stream);
cuco_store_ =
std::make_unique<cuco_set_type>(cuco_size,
cuco::sentinel::empty_key<key_t>{invalid_key},
cuco::empty_key<key_t>{invalid_key},
thrust::equal_to<key_t>{},
cuco::linear_probing<1, // CG size
cuco::murmurhash3_32<key_t>>{},
8 changes: 4 additions & 4 deletions cpp/src/prims/kv_store.cuh
Original file line number Diff line number Diff line change
@@ -823,8 +823,8 @@ class kv_cuco_store_t {
if constexpr (std::is_arithmetic_v<value_t>) {
cuco_store_ =
std::make_unique<cuco_map_type>(cuco_size,
cuco::sentinel::empty_key<key_t>{invalid_key},
cuco::sentinel::empty_value<value_t>{invalid_value},
cuco::empty_key<key_t>{invalid_key},
cuco::empty_value<value_t>{invalid_value},
thrust::equal_to<key_t>{},
cuco::linear_probing<1, // CG size
cuco::murmurhash3_32<key_t>>{},
@@ -835,8 +835,8 @@ class kv_cuco_store_t {
} else {
cuco_store_ = std::make_unique<cuco_map_type>(
cuco_size,
cuco::sentinel::empty_key<key_t>{invalid_key},
cuco::sentinel::empty_value<size_t>{std::numeric_limits<size_t>::max()},
cuco::empty_key<key_t>{invalid_key},
cuco::empty_value<size_t>{std::numeric_limits<size_t>::max()},
thrust::equal_to<key_t>{},
cuco::linear_probing<1, // CG size
cuco::murmurhash3_32<key_t>>{},