-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bug in MG ego_graph
#4262
Fix Bug in MG ego_graph
#4262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Great job on tracking and resolving the egoGraph bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
I removed ops-codeowners from the review list since the current set of files in the PR aren't relevant to ops. |
82248d8
to
546bdb9
Compare
/merge |
1 similar comment
/merge |
Closes #4190
cc: @jnke2016
This PR adds a function to
comms.py
which returns a mapping of workers to ranks. This is then sorted inpart_utils.py
before being used to submit jobs todask
.This should fix a bug in MG
ego_graph
where induced subgraphs were being returned in seemingly random orders (while the results are correct).