Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds nx-cugraph benchmarks for APIs added to prior releases that were never benchmarked #4228

Merged
merged 6 commits into from
Mar 13, 2024
Merged

Adds nx-cugraph benchmarks for APIs added to prior releases that were never benchmarked #4228

merged 6 commits into from
Mar 13, 2024

Conversation

rlratzel
Copy link
Contributor

@rlratzel rlratzel commented Mar 9, 2024

  • Adds benchmark for nx-cugraph pagerank with a personalization dict (see results below)
  • Adds several placeholder benchmarks for other nx-cugraph APIs added to prior releases that were never benchmarked.

image

@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 9, 2024
@rlratzel rlratzel added this to the 24.04 milestone Mar 9, 2024
@rlratzel rlratzel requested a review from eriknw March 9, 2024 08:44
@rlratzel rlratzel self-assigned this Mar 9, 2024
eriknw
eriknw approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@eriknw eriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

What would you think of adding metadata to benchmarks so we know which algorithms they benchmark? This could answer the more important question of what algorithms are not currently benchmarked.

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 6c88281 into rapidsai:branch-24.04 Mar 13, 2024
142 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriknw eriknw eriknw approved these changes

Assignees

@rlratzel rlratzel

Labels
benchmarks improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
24.04
Development

Successfully merging this pull request may close these issues.
4 participants
@rlratzel @BradReesWork @eriknw @nv-rliu