-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hard-coding of RAPIDS version where possible #4217
Remove hard-coding of RAPIDS version where possible #4217
Conversation
Thanks Kyle! 🙏 Think we can also make these changes: rapidsai/build-planning#15 (comment) + rapidsai/build-planning#15 (comment) |
It seems that cugraph is already using that approach: cugraph/python/cugraph/pyproject.toml Line 23 in c17ba39
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs changes look good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++/CUDA changes look good
/merge |
/merge |
/merge |
Thanks all! 🙏 |
…graph (#4240) A [recent PR](#4217) was merged that added `packaging` as a runtime dependency to nx-cugraph. This PR removes that dependency and manually extracts the `major` and `minor` version numbers instead. Authors: - Rick Ratzel (https://github.com/rlratzel) - Erik Welch (https://github.com/eriknw) Approvers: - Brad Rees (https://github.com/BradReesWork) - Erik Welch (https://github.com/eriknw) URL: #4240
VERSION
file in CMakecugraph.__version__
in docs buildVERSION
file in shell scriptsci/update-version.sh
Issue: rapidsai/build-planning#15