New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C API for MNMG ECG #4194

Merged

rapids-bot merged 12 commits into rapidsai:branch-24.04 from naimnv:ecg_c_api

Mar 7, 2024

Contributor

naimnv commented Feb 26, 2024 •

edited by ChuckHastings

Loading

C API for MNMG ECG

Closes #3571
Closes #3572
Closes #3573
Closes #3575


          C API for MNMG ECG

9e943cd

naimnv requested review from a team as code owners

February 26, 2024 22:13

copy-pr-bot bot commented Feb 26, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

github-actions bot added cuGraph CMake python labels

naimnv requested review from ChuckHastings, seunghwak and jnke2016

February 26, 2024 22:14

naimnv self-assigned this

naimnv added this to the 24.04 milestone

ChuckHastings reviewed

View reviewed changes

cpp/tests/c_api/mg_ecg_test.c Outdated Show resolved Hide resolved

ChuckHastings added improvement breaking labels


          Update ECG test code

98cee66

Collaborator

ChuckHastings commented Feb 26, 2024

Labeling a BREAKING change, although the breakage is the renaming of the legacy C API implementation, it is not expected that there are any current users of the legacy C API other than the python layer which is corrected in this PR.

Naim and others added 2 commits

February 26, 2024 23:41


          Fix copyright

cf5c8a0


          Merge branch 'branch-24.04' into ecg_c_api

89c03e1

Contributor Author

naimnv commented Feb 26, 2024

/okay to test

jnke2016 reviewed

View reviewed changes

cpp/include/cugraph_c/community_algorithms.h Show resolved Hide resolved

jnke2016 reviewed

View reviewed changes

cpp/include/cugraph_c/community_algorithms.h Show resolved Hide resolved

jnke2016 reviewed

View reviewed changes

cpp/src/c_api/ecg.cpp Show resolved Hide resolved

jnke2016 reviewed

View reviewed changes

cpp/tests/c_api/mg_ecg_test.c Outdated Show resolved Hide resolved

jnke2016 reviewed

View reviewed changes

cpp/tests/c_api/ecg_test.c Outdated Show resolved Hide resolved

jnke2016 reviewed

View reviewed changes

cpp/tests/c_api/ecg_test.c Show resolved Hide resolved

jnke2016 reviewed

View reviewed changes

cpp/tests/c_api/ecg_test.c Outdated Show resolved Hide resolved

jnke2016 reviewed

View reviewed changes

cpp/tests/c_api/legacy_ecg_test.c Show resolved Hide resolved

jnke2016 reviewed

View reviewed changes

cpp/tests/c_api/mg_ecg_test.c Show resolved Hide resolved

jnke2016 reviewed

View reviewed changes

cpp/tests/c_api/mg_ecg_test.c Outdated Show resolved Hide resolved

jnke2016 reviewed

View reviewed changes

cpp/tests/c_api/mg_ecg_test.c Show resolved Hide resolved

jnke2016 reviewed

View reviewed changes

Contributor

jnke2016 left a comment

The PR looks good overall. Just few minor comments.

seunghwak approved these changes

View reviewed changes

Contributor

seunghwak left a comment

LGTM except for the comments from Joseph.

cpp/tests/c_api/ecg_test.c Show resolved Hide resolved

Naim added 2 commits

February 29, 2024 13:27


          Update test functions to remove unused parameters

86b0faa


          Update mg capi ecg test

cecac32

Contributor Author

naimnv commented Feb 29, 2024

/okay to test

1 similar comment

Contributor Author

naimnv commented Feb 29, 2024

/okay to test

jnke2016 approved these changes

View reviewed changes

Contributor

jnke2016 left a comment

Thanks for addressing those minor change requests. Looks good to me

Naim and others added 3 commits

February 29, 2024 22:25


          Remove merge conflict

f9e97ef


          Merge branch 'branch-24.04' into ecg_c_api

6123d40


          Remove duplicate test file

6cbfe44

Contributor Author

naimnv commented Feb 29, 2024

/okay to test


          clang format

248ca4e

Contributor Author

naimnv commented Feb 29, 2024

/okay to test


          clang format

9b28492

Contributor Author

naimnv commented Feb 29, 2024

/okay to test


          Merge branch 'branch-24.04' into ecg_c_api

3c7fce7

Contributor Author

naimnv commented Mar 7, 2024

/okay to test

Member

BradReesWork commented Mar 7, 2024

/merge

BradReesWork approved these changes

View reviewed changes

rapids-bot bot merged commit 72401a0 into rapidsai:branch-24.04

136 checks passed

rlratzel reviewed

View reviewed changes

Contributor

rlratzel left a comment

Sorry for the late review. This LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ChuckHastings ChuckHastings left review comments

rlratzel rlratzel left review comments

jnke2016 jnke2016 approved these changes

seunghwak seunghwak approved these changes

BradReesWork BradReesWork approved these changes

Labels

breaking CMake cuGraph improvement python