Adds additional detail to Jaccard notebook #4189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd more detail to Jaccard description, add cell output, add example of vertex_pair arg.
rlratzel
added
improvement
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
acostadon
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
My only comment is that usually we don't include output in the notebooks that we check in.
I see arguments for including it or not.
Personally, as long as it doesn't make it so long as to make it difficult to read, I am fine with leaving it in.
Changes look good.
…4-jaccard_notebook_update
BradReesWork
approved these changes
Feb 27, 2024
…4-jaccard_notebook_update
…to a blog on similarity algos.
|
/merge |
rapids-bot
bot
merged commit ac65b17
into
rapidsai:branch-24.04
141 of 142 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to PR #4176 to add additional detail to the Jaccard notebook.
vertex_pairarg