Enforce matching type #4161
Merged
Enforce matching type #4161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4_enforce-dtype-match
…4_enforce-dtype-match
naimnv
reviewed
Feb 13, 2024
naimnv
requested review from
benfred,
rlratzel and
ChuckHastings
and removed request for
benfred
ChuckHastings
approved these changes
Feb 13, 2024
seunghwak
approved these changes
Feb 28, 2024
…4_enforce-dtype-match
naimnv
approved these changes
Mar 10, 2024
…4_enforce-dtype-match
rlratzel
requested changes
Mar 11, 2024
| @@ -165,8 +163,22 @@ def test_node2vec( | |||
| ) | |||
| num_verts = G.number_of_vertices() | |||
| k = random.randint(6, 12) | |||
| start_vertices = cudf.Series(random.sample(range(num_verts), k), dtype="int32") | |||
| start_vertices = cudf.Series( | |||
| random.sample(range(num_verts), k), dtype=start_vertices_type | |||
There was a problem hiding this comment.
Maybe this is a FIXME, but if we're picking samples at random it could make it hard to repro a test failure. We should somehow make it so tests with specific samples can be re-run in the event that the test fails.
There was a problem hiding this comment.
Right. The samples are random so that the test doesn't cover a fixed set of start vertices but I do agree it makes it hard to debug. Perhaps we can add a print those start_vertices for debugging purposes? I added a FIXME regarding this.
BradReesWork
added
improvement
rlratzel
approved these changes
Mar 13, 2024
|
/merge |
rapids-bot
bot
merged commit 728ffd0
into
rapidsai:branch-24.04
136 of 137 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces that the
vertexand thestart_verticesare of the same type and throws a warning in the python API and an exception in the CAPI when there is a mismatch.closes #4094