Implement new All Pairs similarity algorithm #4134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
improvement
ChuckHastings
commented
Feb 1, 2024
| @@ -277,6 +277,7 @@ class Tests_Multithreaded | |||
|
|
|||
| std::tie(std::ignore, modularity) = cugraph::louvain<vertex_t, edge_t, weight_t, true>( | |||
| thread_handle.raft_handle(), | |||
| std::nullopt, | |||
There was a problem hiding this comment.
We somehow missed this in the ECG update... we don't regularly compile the MTMG code in CI.
|
This branch got corrupted and pushed. Closing with a new PR from a cleaner branch. |
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 7, 2024
Added a new entry point for similarity functionality that combines the functionality of k_hop_nbrs and similarity. This entry point allows us to compute similarity for all pairs of vertices in the graph in a single call. We also add the optional parameter topk which, if specified, will only return the vertices that have the highest scores. If topk is specified on an all pairs call, we compute the scores for pairs in batches and extract the topk as we go along to keep the memory footprint low. This PR also updates a FIXME in the C++ similarity test. The C++ similarity test had been written before we had a k_hop_nbrs call, so there was some inefficient test code to compute that. Now that we have a k_hop_nbrs call, the test code was refactored to use that call. Supersedes PR #4134 Authors: - Chuck Hastings (https://github.com/ChuckHastings) Approvers: - Seunghwa Kang (https://github.com/seunghwak) URL: #4158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new entry point for similarity functionality that combines the functionality of
k_hop_nbrsand similarity.This entry point allows us to compute similarity for all pairs of vertices in the graph in a single call. We also add the optional parameter
topkwhich, if specified, will only return the vertices that have the highest scores. Iftopkis specified on an all pairs call, we compute the scores for pairs in batches and extract the topk as we go along to keep the memory footprint low.This PR also updates a FIXME in the C++ similarity test. The C++ similarity test had been written before we had a
k_hop_nbrscall, so there was some inefficient test code to compute that. Now that we have ak_hop_nbrscall, the test code was refactored to use that call.