Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-run ci/release/update-version.sh 24.04.00 #4127

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Jan 30, 2024

Looks like ci/release/update-version.sh may not have been run for 24.04.00. This does that

Also noticed the following errors on macOS. Not sure if these are important. Could someone please double check?

sed: 1: "/^ucx_py_version:$/ {n; ...": bad flag in substitute command: '}'
sed: 1: "/^ucx_py_version:$/ {n; ...": bad flag in substitute command: '}'
sed: 1: "/^ucx_py_version:$/ {n; ...": bad flag in substitute command: '}'

Edit: Should add do see the right ucx_py_version values in these locations. So it does already appear to be correctly updated already

ucx_py_version:
- "0.37.*"

ucx_py_version:
- "0.37.*"

ucx_py_version:
- "0.37.*"

@jakirkham jakirkham requested review from a team as code owners January 30, 2024 23:55
@jakirkham jakirkham mentioned this pull request Jan 30, 2024
@jakirkham jakirkham added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 31, 2024
@raydouglass
Copy link
Member

may not have been run for 24.04.00

Looks like these were 24.02 changes merged (#4123) after branch-24.04 was created.

Also noticed the following errors on macOS.

This is because MacOS ships with BSD sed. BSD sed doesn't parse the commands the same as GNU sed. We try to write things so that the commands will work with either, but sometimes it may not be possible.

@raydouglass raydouglass merged commit 26efc6d into rapidsai:branch-24.04 Feb 1, 2024
59 of 68 checks passed
@jakirkham jakirkham deleted the rerun_update_ver branch February 1, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants