-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new notebook for SNMG benchmark runs #4091
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me.
just need to add your changes to the notebook credits and add 2024 to the copyrights at the bottom,
I ran it on my workstation up to scale 24 on a 2-GPU workstation and it ran perfectly.
Running on scale 25 now.
You need to create a new Notebook and not just add MG to this notebook. The issue is that the notebook compare against NetworkX and Nx does not support DASK or any distributed data. You would need to update the code to always collect that data back to a single host. This will not work in MG dask_cudf does not have a "to_pandas" function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a new Notebook for MG
Sure. We decided not to merge it last week. |
@BradReesWork Just to let you know, the updated notebook's From correctness point of view, this code will always work. But I agree that we need to collect the benchmark graphs back to single host and run Nx algorithms on them. |
Early next week, I can work on this again to make a Notebook for MG. |
@BradReesWork @acostadon |
/ok to test |
/ok to test |
/ok to test |
/ok to test |
/merge |
This PR adds new notebook for SNMG benchmark runs. It