Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match weight-sharing option of GATConv in DGL #4074

Merged
merged 10 commits into from
Jan 23, 2024
Merged

Match weight-sharing option of GATConv in DGL #4074

merged 10 commits into from
Jan 23, 2024

Conversation

tingyu66
Copy link
Member

@tingyu66 tingyu66 commented Jan 2, 2024

Closes #4060

@tingyu66 tingyu66 added this to the 24.02 milestone Jan 2, 2024
@tingyu66 tingyu66 self-assigned this Jan 2, 2024
@github-actions github-actions bot added the python label Jan 2, 2024
@tingyu66 tingyu66 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 2, 2024
@tingyu66 tingyu66 marked this pull request as ready for review January 9, 2024 21:02
@tingyu66 tingyu66 requested a review from a team as a code owner January 9, 2024 21:02
@tingyu66 tingyu66 requested a review from VibhuJawa January 9, 2024 21:02
alexbarghi-nv
alexbarghi-nv approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@alexbarghi-nv alexbarghi-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the code in question but this looks fine to me. I would wait until Vibhu reviews before merging.

VibhuJawa
VibhuJawa approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from a non blocking nitpick.

python/cugraph-dgl/tests/nn/test_transformerconv.py Outdated Show resolved Hide resolved
VibhuJawa
VibhuJawa approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 6774abc into rapidsai:branch-24.02 Jan 23, 2024
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbarghi-nv alexbarghi-nv alexbarghi-nv approved these changes

@VibhuJawa VibhuJawa VibhuJawa approved these changes

Assignees

@tingyu66 tingyu66

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Milestone
24.02
Development

Successfully merging this pull request may close these issues.

[cugraph-dgl] improve alignment of GATConv with DGL's native version
4 participants
@tingyu66 @BradReesWork @VibhuJawa @alexbarghi-nv