Add support for Louvain to MTMG #4033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
improvement
seunghwak
reviewed
Dec 4, 2023
cpp/src/mtmg/vertex_result.cu
Outdated
| template rmm::device_uvector<float> vertex_result_view_t<float>::gather( | ||
| handle_t const& handle, | ||
| raft::device_span<int32_t const> vertices, | ||
| cugraph::mtmg::graph_view_t<int32_t, int32_t, false, false> const& graph_view, |
There was a problem hiding this comment.
Should we really take graph_view here or we can just take vertex partitioning ranges? Many of these explicit instantiations won't be necessary if we just take something like vertex_partition_range_lasts (https://github.com/rapidsai/cugraph/blob/branch-24.02/cpp/include/cugraph/graph_functions.hpp#L237).
LGTM otherwise.
There was a problem hiding this comment.
Updated in latest push.
naimnv
approved these changes
Dec 6, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added vertex result instantiation for
vertex_twhich is necessary to handle Louvain results.Added an MTMG test for Louvain to demonstrate how to use Louvain in MTMG.
Closes https://github.com/rapidsai/graph_dl/issues/330