Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CuGraph compatibility fixes #3973

Merged
merged 5 commits into from
Nov 8, 2023
Merged

CuGraph compatibility fixes #3973

merged 5 commits into from
Nov 8, 2023

Conversation

brandon-b-miller
Copy link
Contributor

This PR contains two changes.

  • A change that defers to numpy.asarray to process array objects that cugraph consumes
  • An update from using unique to use drop_duplicates in simpleGraph.py, which always always returns a Series to preserve pandas compatibility.

@brandon-b-miller brandon-b-miller requested a review from a team as a code owner November 2, 2023 23:55
rlratzel
rlratzel approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brandon-b-miller
Copy link
Contributor Author

failing just a few tests here - looking into it.

@alexbarghi-nv alexbarghi-nv added this to the 23.12 milestone Nov 7, 2023
@alexbarghi-nv alexbarghi-nv added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 7, 2023
@brandon-b-miller
Copy link
Contributor Author

Could someone with permission rerun the one failing job? I think the failure could be transient

pip._vendor.urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='files.pythonhosted.org', port=443): Read timed out.

@alexbarghi-nv
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 9b9ce55 into rapidsai:branch-23.12 Nov 8, 2023
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

Assignees

@brandon-b-miller brandon-b-miller

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
23.12
Development

Successfully merging this pull request may close these issues.
3 participants
@brandon-b-miller @alexbarghi-nv @rlratzel