Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds logic to handle isolated vertices at python layer #3886

Merged
merged 14 commits into from
Sep 29, 2023
Merged

Adds logic to handle isolated vertices at python layer #3886

merged 14 commits into from
Sep 29, 2023

Conversation

naimnv
Copy link
Contributor

@naimnv naimnv commented Sep 26, 2023 •
edited
Loading

  • Adds logic to handle isolated vertices
  • Clamp downs max level to a sane number

closes #3804

@naimnv naimnv requested a review from a team as a code owner September 26, 2023 18:47
@naimnv naimnv self-assigned this Sep 26, 2023
@naimnv naimnv added bug Something isn't working non-breaking Non-breaking change labels Sep 26, 2023
@naimnv naimnv added this to the 23.10 milestone Sep 26, 2023
@naimnv naimnv requested review from jnke2016 and rlratzel September 26, 2023 18:50
rlratzel
rlratzel requested changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One request: can you add a test that has a small inline graph with at least one isolated vertex to verify that these changes work?

@eriknw eriknw mentioned this pull request Sep 28, 2023
Merged
@BradReesWork
Copy link
Member

/merge

@eriknw eriknw mentioned this pull request Sep 28, 2023
Merged
@rapids-bot rapids-bot bot merged commit 6e5e066 into rapidsai:branch-23.10 Sep 29, 2023
rapids-bot bot pushed a commit that referenced this pull request Oct 3, 2023
@eriknw
nx-cugraph: handle louvain with isolated nodes (#3897)
5ce3ee1 
This handles isolated nodes in `louvain_communities` similar to what is done in #3886. This is expected to be a temporary fix until pylibcugraph can handle isolated nodes.

As a bonus, I added `isolates` algorithm 🎉

CC @naimnv @rlratzel

Authors:
  - Erik Welch (https://github.com/eriknw)

Approvers:
  - Rick Ratzel (https://github.com/rlratzel)

URL: #3897
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlratzel rlratzel rlratzel approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@jnke2016 jnke2016 jnke2016 approved these changes

Assignees

@naimnv naimnv

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
23.10
Development

Successfully merging this pull request may close these issues.

[BUG]: cugraph.louvain does not handle empty graphs well
5 participants
@naimnv @BradReesWork @rlratzel @ChuckHastings @jnke2016