Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WholeGraph Feature Store for cuGraph-PyG and cuGraph-DGL #3874

Merged
merged 31 commits into from
Sep 30, 2023
Merged

WholeGraph Feature Store for cuGraph-PyG and cuGraph-DGL #3874

merged 31 commits into from
Sep 30, 2023

Conversation

alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented Sep 23, 2023 •
edited
Loading

Created based on code from @dongxuy04

Adds support for WholeGraph WholeMemory in the cuGraph FeatureStore class. This enables both DGL and PyG to take advantage of distributed feature store functionality.

Adds pylibwholegraph as a testing dependency so the feature store can be tested. Adds appropriate SG and MG tests.

@alexbarghi-nv alexbarghi-nv added feature request New feature or request non-breaking Non-breaking change labels Sep 23, 2023
@alexbarghi-nv alexbarghi-nv added this to the 23.10 milestone Sep 23, 2023
@alexbarghi-nv alexbarghi-nv self-assigned this Sep 23, 2023
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review September 26, 2023 14:30
@alexbarghi-nv alexbarghi-nv requested review from a team as code owners September 26, 2023 14:30
raydouglass
raydouglass requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@raydouglass raydouglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update-version.sh needs to be updated for this new dependency. Probably just adding it to the list here.

VibhuJawa
VibhuJawa suggested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a minot change around API

python/cugraph/cugraph/gnn/feature_storage/feat_storage.py Outdated Show resolved Hide resolved
VibhuJawa
VibhuJawa approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BradReesWork
Copy link
Member

/merge

1 similar comment
@alexbarghi-nv
Copy link
Member Author

/merge

@alexbarghi-nv
Copy link
Member Author

This PR is going to be stuck until we have 23.10 pip packages for WholeGraph

@rapids-bot rapids-bot bot merged commit c00c3f1 into rapidsai:branch-23.10 Sep 30, 2023
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

@VibhuJawa VibhuJawa VibhuJawa approved these changes

@raydouglass raydouglass raydouglass approved these changes

@dongxuy04 dongxuy04 Awaiting requested review from dongxuy04

Assignees

@alexbarghi-nv alexbarghi-nv

Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
23.10
Development

Successfully merging this pull request may close these issues.
4 participants
@alexbarghi-nv @BradReesWork @raydouglass @VibhuJawa