-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Renumber vertices #38
[REVIEW] Renumber vertices #38
Conversation
Can one of the admins verify this patch? |
add to whitelist |
[REVIEW] Fix: Removed cuda_free of unused variable in tsvd_test.cu
|
Not a lot of work. I actually pondered that but didn't want to make it too complex to start. But that's an easy use case to justify. I think it's just a simple editing job to work through which things would be T_in and which would be T_out.
I should have added a comment about those being for testing purposes. I was thinking that those parameters should not be constants. I wasn't sure if we wanted to expose them as parameters or have some heuristic computation based on the number of edges in the graph. |
Let's do it then. I think this is useful.
Perhaps something like this? |
In the renumbered output, should we test that |
[REVIEW] removing cudart_utils include
Created function to renumber source and dest vertices for a graph. Addresses #27
Takes an array of src vertices and dst vertices (assumed to be integer types) and generates a densely packed version of the vertex arrays and a map translating the new vertex ids back to the original vertex ids.