Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Unsupported graph for similiarity algos #3710

Merged
merged 9 commits into from
Jul 19, 2023
Merged

[BUG] Unsupported graph for similiarity algos #3710

merged 9 commits into from
Jul 19, 2023

Conversation

jnke2016
Copy link
Contributor

This PR update the docstrings raises an error when running any similarity algos with vertices from a graph that are unrenumbered.

@jnke2016 jnke2016 requested a review from a team as a code owner July 15, 2023 06:41
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 17, 2023
@jnke2016
Copy link
Contributor Author

Apart from the known WCC, Louvain and Leiden failure, I can't reproduce any of the similarity algos python tests failure locally. Some of them being OOM. I am still looking into it.

@jnke2016
Copy link
Contributor Author

Now we are left with the C++ tests known failures

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 59b0eb7 into rapidsai:branch-23.08 Jul 19, 2023
@jnke2016 jnke2016 mentioned this pull request Aug 4, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradReesWork BradReesWork BradReesWork approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnke2016 @BradReesWork