Sampling modifications to support PyG and DGL options #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
improvement
ChuckHastings
requested review from
VibhuJawa,
seunghwak,
jnke2016,
alexbarghi-nv and
naimnv
|
This looks good so far, I will start testing it now. |
alexbarghi-nv
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Everything appears to be fully functional for both SG and MG. I now have a PR up for the changes to cuGraph-Python and pylibcugraph (#3699)
seunghwak
reviewed
Jul 13, 2023
…/cugraph into sampling_updates_for_23.08
VibhuJawa
approved these changes
Jul 18, 2023
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Jul 19, 2023
Updates pylibcugraph and cuGraph-Python to support the new flags at the C++/C API layer (`unique_sources`, `carry_over_sources`, `deduplicate_sources`. Adds appropriate tests. Fixes a couple cuGraph-Python bugs that the new tests uncovered as well, and properly exposes `return_hops`. Merge after #3696 Authors: - Alex Barghi (https://github.com/alexbarghi-nv) - Vibhu Jawa (https://github.com/VibhuJawa) - Chuck Hastings (https://github.com/ChuckHastings) - Brad Rees (https://github.com/BradReesWork) Approvers: - Rick Ratzel (https://github.com/rlratzel) - Chuck Hastings (https://github.com/ChuckHastings) URL: #3699
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify sampling to add options for managing inclusion of sources on different hops.
Closes #3667
Closes #3665
Closes #3664