-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote datasets
from experimental to stable
#3680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Here's a partial review, I'll add more feedback later.
Some other general feedback is to add unit tests. It would be nice if the meta-data was tested/verified too (eg. the resulting graphs have the same number of vertices and edges as reported in the yaml files) as well as a test to ensure the new warning exceptions are being raised.
Update on unit test coverage suggestions by @rlratzel
|
…e using soon-to-be deleted karate variants from datasets API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking better, thanks! We should also figure out how to refactor the tests that still need the various karate derivatives, or do something else so we can stop importing from experimental.
…u/cugraph into stable-datasets-notebooks
Merge changes to Notebooks and Docstrings
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great !
Not required, but a short README on how to add a new dataset might help users.
…o remove-nx-suppression-warnings
The changes in this PR branch have been merged into #3712 |
This PR moves the
datasets
API from experimental to stable. Users can now do:The
promoted_experimental_warning_wrapper()
has been added to the existingexperimental.datasets
package.closes #3675