-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the neighbor intersection primitive to support edge masking. #3550
Merged
rapids-bot
merged 50 commits into
rapidsai:branch-23.12
from
seunghwak:enh_nbr_intersection_edge_masking
Oct 27, 2023
Merged
Update the neighbor intersection primitive to support edge masking. #3550
rapids-bot
merged 50 commits into
rapidsai:branch-23.12
from
seunghwak:enh_nbr_intersection_edge_masking
Oct 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…br_intersection_edge_masking
…br_intersection_edge_masking
…en iterator's value type != value type)
…br_intersection_edge_masking
…br_intersection_edge_masking
BradReesWork
requested review from
ChuckHastings and
naimnv
and removed request for
acostadon
September 26, 2023 14:10
…edge_property_device_view_t
seunghwak
changed the title
[WIP] Update the neighbor intersection primitive to support edge masking.
Update the neighbor intersection primitive to support edge masking.
Oct 9, 2023
seunghwak
added
feature request
New feature or request
DO NOT MERGE
Hold off on merging; see PR for details
non-breaking
Non-breaking change
labels
Oct 9, 2023
This PR is now ready for review. |
/ok to test |
ChuckHastings
approved these changes
Oct 18, 2023
/ok to test |
naimnv
approved these changes
Oct 19, 2023
jnke2016
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
/ok to test |
/ok to test |
/ok to test |
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the detail::nbr_intersection() primitive and the per_v_pair_transform_dst_nbr_intersection primitive (which calls the detail::nbr_intersection primitive) to work with edge masking (graph_view_t object with attached edge mask). Several utility functions are updated to support edge masking as well to support primitive updates and testing.
This PR is necessary to implement K-truss with the cuGraph C++ primitives. See #3446 (comment) for additional details.
closes #3473
closes #3474