Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the neighbor intersection primitive to support edge masking. #3550

Merged

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented May 9, 2023

This PR updates the detail::nbr_intersection() primitive and the per_v_pair_transform_dst_nbr_intersection primitive (which calls the detail::nbr_intersection primitive) to work with edge masking (graph_view_t object with attached edge mask). Several utility functions are updated to support edge masking as well to support primitive updates and testing.

This PR is necessary to implement K-truss with the cuGraph C++ primitives. See #3446 (comment) for additional details.

closes #3473
closes #3474

@seunghwak seunghwak added this to the 23.06 milestone May 9, 2023
@seunghwak seunghwak self-assigned this May 9, 2023
@ChuckHastings ChuckHastings modified the milestones: 23.06, 23.08 May 23, 2023
@BradReesWork BradReesWork changed the base branch from branch-23.06 to branch-23.08 May 30, 2023 12:54
@BradReesWork BradReesWork modified the milestones: 23.08, 23.10 Jul 25, 2023
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 13, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@seunghwak seunghwak changed the base branch from branch-23.08 to branch-23.10 September 19, 2023 23:09
@BradReesWork BradReesWork requested review from ChuckHastings and naimnv and removed request for acostadon September 26, 2023 14:10
@BradReesWork BradReesWork changed the base branch from branch-23.10 to branch-23.12 September 26, 2023 18:58
@BradReesWork BradReesWork modified the milestones: 23.10, 23.12 Sep 26, 2023
@seunghwak seunghwak changed the title [WIP] Update the neighbor intersection primitive to support edge masking. Update the neighbor intersection primitive to support edge masking. Oct 9, 2023
@seunghwak seunghwak marked this pull request as ready for review October 9, 2023 22:31
@seunghwak seunghwak requested review from a team as code owners October 9, 2023 22:31
@seunghwak seunghwak added feature request New feature or request DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change labels Oct 9, 2023
@seunghwak seunghwak requested a review from jnke2016 October 9, 2023 22:31
@seunghwak seunghwak removed the DO NOT MERGE Hold off on merging; see PR for details label Oct 18, 2023
@seunghwak
Copy link
Contributor Author

This PR is now ready for review.

@ChuckHastings
Copy link
Collaborator

/ok to test

@ChuckHastings
Copy link
Collaborator

/ok to test

Copy link
Contributor

@jnke2016 jnke2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ChuckHastings
Copy link
Collaborator

/ok to test

@seunghwak
Copy link
Contributor Author

/ok to test

@BradReesWork
Copy link
Member

/ok to test

@BradReesWork
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit a57f779 into rapidsai:branch-23.12 Oct 27, 2023
71 checks passed
@seunghwak seunghwak deleted the enh_nbr_intersection_edge_masking branch May 22, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update detail::nbr_intersection to support edge masking Implement edge masking for neighbor intersection
5 participants